fix: allow multi-line function params, lambda params, tuples, and patterns

Added skip_newlines() calls throughout the parser so that newlines are
properly handled in parameter lists, tuple expressions, and pattern
matching constructs. Fixes Issue 5 and Issue 6 from ISSUES.md.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Cargo.lock

@@ -770,7 +770,7 @@ dependencies = [
 
 [[package]]
 name = "lux"
-version = "0.1.4"
+version = "0.1.6"
 dependencies = [
  "lsp-server",
  "lsp-types",

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "lux"
-version = "0.1.5"
+version = "0.1.6"
 edition = "2021"
 description = "A functional programming language with first-class effects, schema evolution, and behavioral types"
 license = "MIT"

flake.nix

@@ -44,7 +44,7 @@
             printf "\n"
             printf "  \033[1;35m╦  ╦ ╦╦ ╦\033[0m\n"
             printf "  \033[1;35m║  ║ ║╔╣\033[0m\n"
-            printf "  \033[1;35m╩═╝╚═╝╩ ╩\033[0m  v0.1.5\n"
+            printf "  \033[1;35m╩═╝╚═╝╩ ╩\033[0m  v0.1.6\n"
             printf "\n"
             printf "  Functional language with first-class effects\n"
             printf "\n"
@@ -62,7 +62,7 @@
 
         packages.default = pkgs.rustPlatform.buildRustPackage {
           pname = "lux";
-          version = "0.1.5";
+          version = "0.1.6";
           src = ./.;
           cargoLock.lockFile = ./Cargo.lock;
 
@@ -79,7 +79,7 @@
           };
         in muslPkgs.rustPlatform.buildRustPackage {
           pname = "lux";
-          version = "0.1.5";
+          version = "0.1.6";
           src = ./.;
           cargoLock.lockFile = ./Cargo.lock;
 

src/codegen/c_backend.rs

@@ -146,6 +146,8 @@ pub struct CBackend {
     imported_modules: HashSet<String>,
     /// Variable name renames: Lux name → C variable name (for let binding name mangling)
     var_renames: HashMap<String, String>,
+    /// Inner type for Option-typed variables (variable name -> inner C type, e.g. "LuxInt")
+    var_option_inner_types: HashMap<String, String>,
 }
 
 impl CBackend {
@@ -177,6 +179,7 @@ impl CBackend {
             module_functions: HashMap::new(),
             imported_modules: HashSet::new(),
             var_renames: HashMap::new(),
+            var_option_inner_types: HashMap::new(),
         }
     }
 
@@ -279,7 +282,7 @@ impl CBackend {
                 Declaration::Let(let_decl) => {
                     // Skip run expressions - they're handled in the main wrapper
                     if !matches!(&let_decl.value, Expr::Run { .. }) {
-                        self.emit_global_let(&let_decl.name)?;
+                        self.emit_global_let(let_decl)?;
                     }
                 }
                 _ => {}
@@ -599,6 +602,18 @@ impl CBackend {
         self.writeln(&format!("{} {}({}) {{", ret_type, mangled_name, full_params));
         self.indent += 1;
 
+        // Register parameter types so match/option inference can use them
+        for p in &func.params {
+            if let Ok(c_type) = self.type_expr_to_c(&p.typ) {
+                let escaped = self.escape_c_keyword(&p.name.name);
+                self.var_types.insert(escaped.clone(), c_type);
+                // Track Option inner types for match pattern extraction
+                if let Some(inner) = self.option_inner_type_from_type_expr(&p.typ) {
+                    self.var_option_inner_types.insert(escaped, inner);
+                }
+            }
+        }
+
         let old_has_evidence = self.has_evidence;
         if is_effectful {
             self.has_evidence = true;
@@ -1149,6 +1164,7 @@ impl CBackend {
         self.writeln("    void (*delete_file)(void* env, LuxString path);");
         self.writeln("    LuxBool (*isDir)(void* env, LuxString path);");
         self.writeln("    void (*mkdir)(void* env, LuxString path);");
+        self.writeln("    void (*copy)(void* env, LuxString src, LuxString dst);");
         self.writeln("    LuxList* (*readDir)(void* env, LuxString path);");
         self.writeln("    void* env;");
         self.writeln("} LuxFileHandler;");
@@ -1336,6 +1352,20 @@ impl CBackend {
         self.writeln("    mkdir(path, 0755);");
         self.writeln("}");
         self.writeln("");
+        self.writeln("static void lux_file_copy(LuxString src, LuxString dst) {");
+        self.writeln("    FILE* fin = fopen(src, \"rb\");");
+        self.writeln("    if (!fin) return;");
+        self.writeln("    FILE* fout = fopen(dst, \"wb\");");
+        self.writeln("    if (!fout) { fclose(fin); return; }");
+        self.writeln("    char buf[4096];");
+        self.writeln("    size_t n;");
+        self.writeln("    while ((n = fread(buf, 1, sizeof(buf), fin)) > 0) {");
+        self.writeln("        fwrite(buf, 1, n, fout);");
+        self.writeln("    }");
+        self.writeln("    fclose(fin);");
+        self.writeln("    fclose(fout);");
+        self.writeln("}");
+        self.writeln("");
         self.writeln("#include <dirent.h>");
         self.writeln("// Forward declarations needed by lux_file_readDir");
         self.writeln("static LuxList* lux_list_new(int64_t capacity);");
@@ -1391,6 +1421,11 @@ impl CBackend {
         self.writeln("    lux_file_mkdir(path);");
         self.writeln("}");
         self.writeln("");
+        self.writeln("static void default_file_copy(void* env, LuxString src, LuxString dst) {");
+        self.writeln("    (void)env;");
+        self.writeln("    lux_file_copy(src, dst);");
+        self.writeln("}");
+        self.writeln("");
         self.writeln("static LuxList* default_file_readDir(void* env, LuxString path) {");
         self.writeln("    (void)env;");
         self.writeln("    return lux_file_readDir(path);");
@@ -1404,6 +1439,7 @@ impl CBackend {
         self.writeln("    .delete_file = default_file_delete,");
         self.writeln("    .isDir = default_file_isDir,");
         self.writeln("    .mkdir = default_file_mkdir,");
+        self.writeln("    .copy = default_file_copy,");
         self.writeln("    .readDir = default_file_readDir,");
         self.writeln("    .env = NULL");
         self.writeln("};");
@@ -2124,20 +2160,6 @@ impl CBackend {
         self.writeln("static Option lux_option_none(void) { return (Option){Option_TAG_NONE}; }");
         self.writeln("static Option lux_option_some(void* value) { return (Option){Option_TAG_SOME, .data.some = {value}}; }");
         self.writeln("");
-        self.writeln("// String indexOf / lastIndexOf — return Option<Int>");
-        self.writeln("static Option lux_string_indexOf(LuxString s, LuxString needle) {");
-        self.writeln("    char* pos = strstr(s, needle);");
-        self.writeln("    if (pos) return lux_option_some((void*)(intptr_t)(pos - s));");
-        self.writeln("    return lux_option_none();");
-        self.writeln("}");
-        self.writeln("static Option lux_string_lastIndexOf(LuxString s, LuxString needle) {");
-        self.writeln("    char* last = NULL;");
-        self.writeln("    char* pos = strstr(s, needle);");
-        self.writeln("    while (pos) { last = pos; pos = strstr(pos + 1, needle); }");
-        self.writeln("    if (last) return lux_option_some((void*)(intptr_t)(last - s));");
-        self.writeln("    return lux_option_none();");
-        self.writeln("}");
-        self.writeln("");
         self.writeln("// === Boxing/Unboxing ===");
         self.writeln("// All boxed values are RC-managed.");
         self.writeln("");
@@ -2171,6 +2193,20 @@ impl CBackend {
         self.writeln("}");
         self.writeln("static LuxString lux_unbox_string(void* p) { return (LuxString)p; }");
         self.writeln("");
+        self.writeln("// String indexOf / lastIndexOf — return Option<Int>");
+        self.writeln("static Option lux_string_indexOf(LuxString s, LuxString needle) {");
+        self.writeln("    char* pos = strstr(s, needle);");
+        self.writeln("    if (pos) return lux_option_some(lux_box_int((LuxInt)(pos - s)));");
+        self.writeln("    return lux_option_none();");
+        self.writeln("}");
+        self.writeln("static Option lux_string_lastIndexOf(LuxString s, LuxString needle) {");
+        self.writeln("    char* last = NULL;");
+        self.writeln("    char* pos = strstr(s, needle);");
+        self.writeln("    while (pos) { last = pos; pos = strstr(pos + 1, needle); }");
+        self.writeln("    if (last) return lux_option_some(lux_box_int((LuxInt)(last - s)));");
+        self.writeln("    return lux_option_none();");
+        self.writeln("}");
+        self.writeln("");
         self.writeln("// === Polymorphic Drop Function ===");
         self.writeln("// Called when an object's refcount reaches zero.");
         self.writeln("// Recursively decrefs any owned references before freeing.");
@@ -2706,7 +2742,11 @@ impl CBackend {
         for param in &func.params {
             let escaped = self.escape_c_keyword(&param.name.name);
             if let Ok(c_type) = self.type_expr_to_c(&param.typ) {
-                self.var_types.insert(escaped, c_type);
+                self.var_types.insert(escaped.clone(), c_type);
+                // Track Option inner types for match pattern extraction
+                if let Some(inner) = self.option_inner_type_from_type_expr(&param.typ) {
+                    self.var_option_inner_types.insert(escaped, inner);
+                }
             }
         }
 
@@ -3067,6 +3107,13 @@ impl CBackend {
                 // Infer the type from the value expression
                 let var_type = self.infer_expr_type(value).unwrap_or_else(|| "LuxInt".to_string());
 
+                // Track Option inner type for match pattern extraction
+                if var_type == "Option" {
+                    if let Some(inner) = self.infer_option_inner_type(value) {
+                        self.var_option_inner_types.insert(var_name.clone(), inner);
+                    }
+                }
+
                 self.writeln(&format!("{} {} = {};", var_type, var_name, val));
 
                 // Register the variable rename so nested expressions can find it
@@ -3375,6 +3422,13 @@ impl CBackend {
                             // Record variable type for future inference
                             self.var_types.insert(escaped_name.clone(), typ.clone());
 
+                            // Track Option inner type for match pattern extraction
+                            if typ == "Option" {
+                                if let Some(inner) = self.infer_option_inner_type(value) {
+                                    self.var_option_inner_types.insert(escaped_name.clone(), inner);
+                                }
+                            }
+
                             // Handle ownership transfer or RC registration
                             if let Some(source_name) = source_var {
                                 // Ownership transfer: unregister source, register dest
@@ -3679,6 +3733,16 @@ impl CBackend {
                             }
                             return Ok("NULL".to_string());
                         }
+                        "copy" => {
+                            let src = self.emit_expr(&args[0])?;
+                            let dst = self.emit_expr(&args[1])?;
+                            if self.has_evidence {
+                                self.writeln(&format!("ev->file->copy(ev->file->env, {}, {});", src, dst));
+                            } else {
+                                self.writeln(&format!("lux_file_copy({}, {});", src, dst));
+                            }
+                            return Ok("NULL".to_string());
+                        }
                         "readDir" | "listDir" => {
                             let path = self.emit_expr(&args[0])?;
                             let temp = format!("_readdir_{}", self.fresh_name());
@@ -4841,8 +4905,8 @@ impl CBackend {
                 if c_type == "void*" {
                     // Cast from void* to actual type
                     if Self::is_primitive_c_type(&actual_type) {
-                        // For primitive types stored as void*, cast via intptr_t
-                        self.writeln(&format!("{} {} = ({})(intptr_t)({});", actual_type, var_name, actual_type, c_expr));
+                        // For primitive types stored as boxed void*, dereference
+                        self.writeln(&format!("{} {} = *({}*)({});", actual_type, var_name, actual_type, c_expr));
                     } else if !actual_type.ends_with('*') && actual_type != "void" {
                         // Struct types: cast to pointer and dereference
                         self.writeln(&format!("{} {} = *({}*)({});", actual_type, var_name, actual_type, c_expr));
@@ -5175,7 +5239,7 @@ impl CBackend {
                 } else if effect.name == "File" {
                     match operation.name.as_str() {
                         "read" => Some("LuxString".to_string()),
-                        "write" | "append" | "delete" | "mkdir" => Some("void".to_string()),
+                        "write" | "append" | "delete" | "mkdir" | "copy" => Some("void".to_string()),
                         "exists" | "isDir" => Some("LuxBool".to_string()),
                         "readDir" | "listDir" => Some("LuxList*".to_string()),
                         _ => None,
@@ -5383,7 +5447,13 @@ impl CBackend {
                     None
                 }
             }
-            Expr::Var(_) => None,
+            Expr::Var(ident) => {
+                let escaped = self.escape_c_keyword(&ident.name);
+                // Check renamed variables first, then original name
+                let lookup_name = self.var_renames.get(&ident.name).unwrap_or(&escaped);
+                self.var_option_inner_types.get(lookup_name).cloned()
+                    .or_else(|| self.var_option_inner_types.get(&escaped).cloned())
+            }
             _ => None,
         }
     }
@@ -5561,9 +5631,25 @@ impl CBackend {
         }
     }
 
-    fn emit_global_let(&mut self, name: &Ident) -> Result<(), CGenError> {
-        // Declare global variable without initializer (initialized in main)
-        self.writeln(&format!("static LuxInt {} = 0;", name.name));
+    fn emit_global_let(&mut self, let_decl: &crate::ast::LetDecl) -> Result<(), CGenError> {
+        // Infer type from the value expression (or type annotation)
+        let typ = if let Some(ref type_expr) = let_decl.typ {
+            self.type_expr_to_c(type_expr).unwrap_or_else(|_| "LuxInt".to_string())
+        } else {
+            self.infer_expr_type(&let_decl.value).unwrap_or_else(|| "LuxInt".to_string())
+        };
+        let default = match typ.as_str() {
+            "LuxString" => "NULL",
+            "LuxBool" => "false",
+            "LuxFloat" => "0.0",
+            "LuxList*" | "LuxClosure*" => "NULL",
+            "Option" => "{0}",
+            "Result" => "{0}",
+            _ if typ.ends_with('*') => "NULL",
+            _ => "0",
+        };
+        self.writeln(&format!("static {} {} = {};", typ, let_decl.name.name, default));
+        self.var_types.insert(let_decl.name.name.clone(), typ);
         self.writeln("");
         Ok(())
     }
@@ -5666,6 +5752,20 @@ impl CBackend {
         self.type_expr_to_c(type_expr)
     }
 
+    /// Extract the inner C type from an Option<T> type expression
+    fn option_inner_type_from_type_expr(&self, type_expr: &TypeExpr) -> Option<String> {
+        if let TypeExpr::App(base, args) = type_expr {
+            if let TypeExpr::Named(name) = base.as_ref() {
+                if name.name == "Option" {
+                    if let Some(inner) = args.first() {
+                        return self.type_expr_to_c(inner).ok();
+                    }
+                }
+            }
+        }
+        None
+    }
+
     fn type_expr_to_c(&self, type_expr: &TypeExpr) -> Result<String, CGenError> {
         match type_expr {
             TypeExpr::Named(ident) => {

src/interpreter.rs

@@ -3864,6 +3864,30 @@ impl Interpreter {
                 }
             }
 
+            ("File", "copy") => {
+                let source = match request.args.first() {
+                    Some(Value::String(s)) => s.clone(),
+                    _ => return Err(RuntimeError {
+                        message: "File.copy requires a string source path".to_string(),
+                        span: None,
+                    }),
+                };
+                let dest = match request.args.get(1) {
+                    Some(Value::String(s)) => s.clone(),
+                    _ => return Err(RuntimeError {
+                        message: "File.copy requires a string destination path".to_string(),
+                        span: None,
+                    }),
+                };
+                match std::fs::copy(&source, &dest) {
+                    Ok(_) => Ok(Value::Unit),
+                    Err(e) => Err(RuntimeError {
+                        message: format!("Failed to copy '{}' to '{}': {}", source, dest, e),
+                        span: None,
+                    }),
+                }
+            }
+
             // ===== Process Effect =====
             ("Process", "exec") => {
                 use std::process::Command;

src/main.rs

@@ -5629,4 +5629,55 @@ c")"#;
         "#;
         assert_eq!(eval(source).unwrap(), "Some(30)");
     }
+
+    #[test]
+    fn test_file_copy() {
+        use std::io::Write;
+        // Create a temp file, copy it, verify contents
+        let dir = std::env::temp_dir().join("lux_test_file_copy");
+        let _ = std::fs::create_dir_all(&dir);
+        let src = dir.join("src.txt");
+        let dst = dir.join("dst.txt");
+        std::fs::File::create(&src).unwrap().write_all(b"hello copy").unwrap();
+        let _ = std::fs::remove_file(&dst);
+
+        let source = format!(r#"
+            fn main(): Unit with {{File}} =
+                File.copy("{}", "{}")
+            let _ = run main() with {{}}
+            let result = "done"
+        "#, src.display(), dst.display());
+        let result = eval(&source);
+        assert!(result.is_ok(), "File.copy failed: {:?}", result);
+        let contents = std::fs::read_to_string(&dst).unwrap();
+        assert_eq!(contents, "hello copy");
+
+        // Cleanup
+        let _ = std::fs::remove_dir_all(&dir);
+    }
+
+    #[test]
+    fn test_effectful_callback_propagation() {
+        // WISH-7: effectful callbacks in List.forEach should propagate effects
+        // This should type-check successfully because Console effect is inferred
+        let source = r#"
+            fn printAll(items: List<String>): Unit =
+                List.forEach(items, fn(x: String): Unit => Console.print(x))
+            let result = "ok"
+        "#;
+        let result = eval(source);
+        assert!(result.is_ok(), "Effectful callback should type-check: {:?}", result);
+    }
+
+    #[test]
+    fn test_effectful_callback_in_map() {
+        // Effectful callback in List.map should propagate effects
+        let source = r#"
+            fn readAll(paths: List<String>): List<String> =
+                List.map(paths, fn(p: String): String => File.read(p))
+            let result = "ok"
+        "#;
+        let result = eval(source);
+        assert!(result.is_ok(), "Effectful callback in map should type-check: {:?}", result);
+    }
 }

src/parser.rs

@@ -846,6 +846,7 @@ impl Parser {
     /// Parse function parameters
     fn parse_params(&mut self) -> Result<Vec<Parameter>, ParseError> {
         let mut params = Vec::new();
+        self.skip_newlines();
 
         while !self.check(TokenKind::RParen) {
             let start = self.current_span();
@@ -855,9 +856,11 @@ impl Parser {
             let span = start.merge(self.previous_span());
 
             params.push(Parameter { name, typ, span });
+            self.skip_newlines();
 
             if !self.check(TokenKind::RParen) {
                 self.expect(TokenKind::Comma)?;
+                self.skip_newlines();
             }
         }
 
@@ -1937,11 +1940,14 @@ impl Parser {
 
         if self.check(TokenKind::LParen) {
             self.advance();
+            self.skip_newlines();
             let mut fields = Vec::new();
             while !self.check(TokenKind::RParen) {
                 fields.push(self.parse_pattern()?);
+                self.skip_newlines();
                 if !self.check(TokenKind::RParen) {
                     self.expect(TokenKind::Comma)?;
+                    self.skip_newlines();
                 }
             }
             self.expect(TokenKind::RParen)?;
@@ -1960,12 +1966,15 @@ impl Parser {
     fn parse_tuple_pattern(&mut self) -> Result<Pattern, ParseError> {
         let start = self.current_span();
         self.expect(TokenKind::LParen)?;
+        self.skip_newlines();
 
         let mut elements = Vec::new();
         while !self.check(TokenKind::RParen) {
             elements.push(self.parse_pattern()?);
+            self.skip_newlines();
             if !self.check(TokenKind::RParen) {
                 self.expect(TokenKind::Comma)?;
+                self.skip_newlines();
             }
         }
 
@@ -2095,6 +2104,7 @@ impl Parser {
 
     fn parse_lambda_params(&mut self) -> Result<Vec<Parameter>, ParseError> {
         let mut params = Vec::new();
+        self.skip_newlines();
 
         while !self.check(TokenKind::RParen) {
             let start = self.current_span();
@@ -2110,9 +2120,11 @@ impl Parser {
 
             let span = start.merge(self.previous_span());
             params.push(Parameter { name, typ, span });
+            self.skip_newlines();
 
             if !self.check(TokenKind::RParen) {
                 self.expect(TokenKind::Comma)?;
+                self.skip_newlines();
             }
         }
 
@@ -2200,6 +2212,7 @@ impl Parser {
     fn parse_tuple_or_paren_expr(&mut self) -> Result<Expr, ParseError> {
         let start = self.current_span();
         self.expect(TokenKind::LParen)?;
+        self.skip_newlines();
 
         if self.check(TokenKind::RParen) {
             self.advance();
@@ -2210,16 +2223,19 @@ impl Parser {
         }
 
         let first = self.parse_expr()?;
+        self.skip_newlines();
 
         if self.check(TokenKind::Comma) {
             // Tuple
             let mut elements = vec![first];
             while self.check(TokenKind::Comma) {
                 self.advance();
+                self.skip_newlines();
                 if self.check(TokenKind::RParen) {
                     break;
                 }
                 elements.push(self.parse_expr()?);
+                self.skip_newlines();
             }
             self.expect(TokenKind::RParen)?;
             let span = start.merge(self.previous_span());

src/typechecker.rs

@@ -1951,6 +1951,17 @@ impl TypeChecker {
         let func_type = self.infer_expr(func);
         let arg_types: Vec<Type> = args.iter().map(|a| self.infer_expr(a)).collect();
 
+        // Propagate effects from callback arguments to enclosing scope
+        for arg_type in &arg_types {
+            if let Type::Function { effects, .. } = arg_type {
+                for effect in &effects.effects {
+                    if self.inferring_effects {
+                        self.inferred_effects.insert(effect.clone());
+                    }
+                }
+            }
+        }
+
         // Check property constraints from where clauses
         if let Expr::Var(func_id) = func {
             if let Some(constraints) = self.property_constraints.get(&func_id.name).cloned() {
@@ -2061,6 +2072,18 @@ impl TypeChecker {
                 if let Some((_, field_type)) = fields.iter().find(|(n, _)| n == &operation.name) {
                     // It's a function call on a module field
                     let arg_types: Vec<Type> = args.iter().map(|a| self.infer_expr(a)).collect();
+
+                    // Propagate effects from callback arguments to enclosing scope
+                    for arg_type in &arg_types {
+                        if let Type::Function { effects, .. } = arg_type {
+                            for effect in &effects.effects {
+                                if self.inferring_effects {
+                                    self.inferred_effects.insert(effect.clone());
+                                }
+                            }
+                        }
+                    }
+
                     let result_type = Type::var();
                     let expected_fn = Type::function(arg_types, result_type.clone());
 
@@ -2120,6 +2143,17 @@ impl TypeChecker {
                 // Check argument types
                 let arg_types: Vec<Type> = args.iter().map(|a| self.infer_expr(a)).collect();
 
+                // Propagate effects from callback arguments to enclosing scope
+                for arg_type in &arg_types {
+                    if let Type::Function { effects, .. } = arg_type {
+                        for effect in &effects.effects {
+                            if self.inferring_effects {
+                                self.inferred_effects.insert(effect.clone());
+                            }
+                        }
+                    }
+                }
+
                 if arg_types.len() != op.params.len() {
                     self.errors.push(TypeError {
                         message: format!(

src/types.rs

@@ -956,6 +956,14 @@ impl TypeEnv {
                         params: vec![("path".to_string(), Type::String)],
                         return_type: Type::Unit,
                     },
+                    EffectOpDef {
+                        name: "copy".to_string(),
+                        params: vec![
+                            ("source".to_string(), Type::String),
+                            ("dest".to_string(), Type::String),
+                        ],
+                        return_type: Type::Unit,
+                    },
                 ],
             },
         );